Merge develop into ripple/smart-escrow
#5614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XRPLF#5579) This change includes `network_id` data in the validations and ledger subscription stream responses, as well as unit tests to validate the response fields. Fixes XRPLF#4783
This change renames the `libxrpl` profile to `default` to make it more usable.
Before `XRPLF/ci` images, we did not have a `dependencies:` job for clang-16, so `instrumentation:` had to build its own dependencies. Now we have clang-16 Conan dependencies built in a separate job that can be used.
This change updates RocksDB to its latest version. RocksDB is backward-compatible, so even though this is a major version bump, databases created with previous versions will continue to function. The external RocksDB folder is removed, as the latest version available via Conan Center no longer needs custom patches.
XRPLF#5224 added (among other things) a `VaultWithdraw` transaction that allows setting the recipient of the withdrawn funds in the `Destination` transaction field. This technically turns this transaction into a payment, and in some respect the implementation does follow payment rules, e.g. enforcement of `lsfRequireDestTag` or `lsfDepositAuth`, or that MPT transfer has destination `MPToken`. However for IOUs, it missed verification that the destination account has a trust line to the asset issuer. Since the default behavior of `accountSendIOU` is to create this trust line (if missing), this is what `VaultWithdraw` currently does. This is incorrect, since the `Destination` might not be interested in holding the asset in question; this basically enables spammy transfers. This change, therefore, removes automatic creation of a trust line to the `Destination` account in `VaultWithdraw`.
oleks-rip
approved these changes
Jul 25, 2025
As we no longer support old compiler versions, we are bringing back some warnings by removing no longer relevant `-Wno-...` options.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ripple/smart-escrow #5614 +/- ##
===================================================
Coverage 78.7% 78.7%
===================================================
Files 825 823 -2
Lines 73098 73102 +4
Branches 8548 8603 +55
===================================================
+ Hits 57553 57563 +10
+ Misses 15545 15539 -6
... and 116 files with indirect coverage changes 🚀 New features to boost your workflow:
|
As we no longer support old compiler versions, we are bringing back some warnings by removing no longer relevant `-Wno-...` options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR updates
ripple/smart-escrowto contain the latest on thedevelopbranch.Context of Change
Tests are failing due to complexities in the conan2 upgrade. This PR handles that (alongside other upgrades).
We also need to keep the branch updated.
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
N/A
Test Plan
CI passes